mpfproj Work Item Rss Feed

Created Issue: Cast error when using custom logger. [18105]

tbonemike — Wed, 30 Jun 2010 18:54:55 GMT

I have my own logger class that inherits from Microsoft.Build.Utilities.Logger. This is part of my overall Package implementation in VS2008.
When I run I get a cast error in method SetOutputLogger on this line in ProjectNode.cs --> ((IDEBuildLogger)this.BuildLogger).OutputWindowPane = output;
"Unable to cast object of type Idea.Xgen.XgenLogger.XgenLogger to type Microsoft.VisualStudio.Project.IDEBuildLogger".
I had reported this in the past for VS2005 and it was suggested to get around it for the time being with an IF statement before --> if (this.buildLogger is IDEBuildLogger)
Is this something that needs to be fixed the the MFP source or do I have a bug in my implementation?

Thanks

Commented Issue: Enhancement Request: Support "Add File as Link" functionality [16236]

bralston7 — Mon, 08 Feb 2010 21:45:38 GMT

The MPF should support the ability to "Add as Link" when adding files to a project, just like C# projects do. The Wix Votive project already modified the MPF to do this, and I would be happy to merge in the changes if this is assigned to me.
Comments: ** Comment from web user: bralston7 **

I have changes ready to merge for this enhancement. Moderators, please let me know how I can contribute these changes for review.

Created Issue: Enhancement Request: Support VS2005 SDK [16237]

bralston7 — Wed, 03 Feb 2010 22:39:07 GMT

The MPF can be modified via conditional compilation args (ie. #ifDef VS2005) to work for both VS2005 and VS2008. The Wix Votive project has already done this. I would like to see this change merged into the MPF. This would be very useful for those of us developing extensions for both 2005 and 2008.

Created Issue: Enhancement Request: Support "Add File as Link" functionality [16236]

bralston7 — Wed, 03 Feb 2010 22:36:11 GMT

Commented Issue: Building source causes hard error CA0001 -- exception thrown by FxCop [11507]

petterh — Mon, 28 Sep 2009 15:27:49 GMT

Building this set of source files with code analysis turned on causes a hard error whose message says:
Error 13 CA0001 : Rule=Microsoft.Naming#CA1725, Target=Microsoft.VisualStudio.Project.Automation.OAReferenceBase`1.#get_Extender(System.String) : Object reference not set to an instance of an object. MPFProj

Suppressing the rule in source or in the global suppressions file does _not_ work around this error, but turning off this error in the Code Analysis settings for the project does.

Please modify the source to avoid triggering the rule. I will also post this to the FxCop forums so they can address the problem with rule 1725.
Comments: ** Comment from web user: petterh **

It seems to me this is an issue with FxCop rather than with MPFProj...?

Commented Issue: Building source causes hard error CA0001 -- exception thrown by FxCop [11507]

petterh — Mon, 28 Sep 2009 15:26:13 GMT

Impact = Low is wrong: For us it's a showstopper. Turning off the error in the Code Analysis section for the project helps when you do Run Code Analysis from within Visual Studio, but not when you use msbuild.

Created Issue: Wrong project reference icon is shown in solution explorer (VS2008)

bdicroce — Mon, 11 May 2009 21:11:11 GMT

When adding a project reference (C++, Visual Basic, etc.) to another project in Solution Explorer (right-click project's reference, then click on the Add Reference... menu item), the icon being displayed is not the standard greyish component icon.

In fact, the icon being displayed is the project's icon (The C++ project icon for a C++ reference, for example). We fixed the problem by adding the following instructions at line 143 in the ProjectReferenceNode.cs:

if( prj.Properties == null )
continue;

Here's a sample of part of the current code with our solution from above, so that you can easily search for already existing strings:

//Skip this project if it is an umodeled project (unloaded)
if(string.Compare(EnvDTE.Constants.vsProjectKindUnmodeled, prj.Kind, StringComparison.OrdinalIgnoreCase) == 0)
{
continue;
}

// Get the full path of the current project.
EnvDTE.Property pathProperty = null;
try
{
// OUR SOLUTION BEGINS HERE
if( prj.Properties == null )
continue;
// OUR SOLUTION ENDS HERE
pathProperty = prj.Properties.Item("FullPath");
if(null == pathProperty)
{
// The full path should alway be availabe, but if this is not the
// case then we have to skip it.
continue;
}
}

Commented Issue: OAProperties.Item can't find "URL" index

cmaxo — Mon, 27 Apr 2009 22:12:34 GMT

I'm creating a language service for a simple DSL. While working in the experimental hive, MPFProj quite often throws an exception in OAProperties.Item when the index argument equals "URL". The call stack shows nothing but [External Code] and this function. The exception occurs when I close the solution or exit Visual Studio, but it also occurs sometimes when I open the project. I can't seem to determine the origin of the "URL" property, why it's needed, or how to provide it.
Comments: ** Comment from web user: cmaxo **

I found a solution to this problem without having to modify the cs files provided by this project. The file type that I was adding needed to have a class that "presents" properties to visual studio and that class needs to have a "public string URL..." property. The class that I created that subclasses from FileNode has this method now:

protected override NodeProperties CreatePropertiesObject()
{
MyFileNodeProperties properties = new MyFileNodeProperties(this);
properties.OnCustomToolChanged += new EventHandler<HierarchyNodeEventArgs>(OnCustomToolChanged);
properties.OnCustomToolNameSpaceChanged += new EventHandler<HierarchyNodeEventArgs>(OnCustomToolNameSpaceChanged);
return properties;
}

And MyFileNodeProperties has among other things the URL property.

Corey

Created Issue: VS.NET Solution Explorer Drag & Drop for C++ projects does not work

ahmedkabir — Wed, 22 Apr 2009 20:30:49 GMT

Hi,

I am trying to implement 'Drag&Drop' functionality from solution explorer in VS.NET 2005 onto my C# winform.
I have 2 projects within same solution (one C# project, and other MFC C++ project). I have implemented the following events & properties in my C# winform.
My winform contains just one textbox.
1. DragEnter - for textbox
2. DragOver - for textbox
3. AllowDrop property - for textbox
Also tried with different 'DragDropEffects' enumeration values.

Problem:
When I 'Drag&Drop' C# file to my winform, I am able to retrieve the dragged project file path, but the same does not work with C++/Header files and even with project file (csproj, vcproj, etc). While dragging C++/Header file, the mouse cursor shows 'None' (a circle with a line through it), but works fine with C# file.

Can anyone please help me? I have attached the sample C# winform project.

Thanks in advance,
Ahmed Kabir
ahmed.kabir@yahoo.com

Created Issue: Adding an item to a project with subfolders asserts

oeieno — Tue, 21 Apr 2009 21:45:07 GMT

The assert is in OAProjectItems.cs at line 193:

Debug.Assert(nodeAdded != null, "We should have been able to find the new element in the hierarchy");

It fails when trying to find a hierarchy node because the name that is passed in is an absolute path, and the virtual node name of each tree node is just the file name with no path information included. The problem doesn't seem to occur with flat projects. I fixed the problem by changing HierarchyNode.FindChild() to check for FileNodes in the search loop, and check "name" against the Url property of FileNodes.

Commented Issue: OAProperties.Item can't find "URL" index

cmaxo — Thu, 09 Apr 2009 22:01:41 GMT

I confirmed that by adding the code from kobrigo as a property on NodeProperties the exception goes away. Can anybody explain why the samples don't have this issue or where the root of the problem comes from? I feel dirty having this little hack and no explanation.

Thanks,
cmaxo

Commented Issue: OAProperties.Item can't find "URL" index

kobrigo — Sun, 29 Mar 2009 11:37:50 GMT

I did not slove the issue I just added the missing attribute so stop the exeptions for now. Here is what I did.
I have added in the file NodeProperties.cs on the class NodeProperties the following attribute which solved the issue:
[SRCategoryAttribute(SR.Misc)]
[LocDisplayName(SR.URL)]
[SRDescriptionAttribute(SR.URL)]
public string URL
{
get
{
return this.Node.Url;
}
}

Hope this helps you

Created Issue: OAProperties.Item can't find "URL" index

canopus51 — Tue, 03 Mar 2009 00:47:23 GMT

Created Issue: ProjectNode.WalkSourceProjectAndAdd() contains bug

QuanTo — Tue, 10 Feb 2009 03:31:06 GMT

Problem Description: WalkSourceProjectAndAdd() method of ProjectNode class contains 2 errors. The bug appears in Drag'n'Drop operations. When I drag and drop folder which contains several file nodes it tries to create the same file several times.

Your code:
------------------
if (addSiblings)
{
// Then look at siblings
currentItemID = itemId;
while (currentItemID != VSConstants.VSITEMID_NIL)
{
variant = null;
ErrorHandler.ThrowOnFailure(sourceHierarchy.GetProperty(itemId, (int)__VSHPROPID.VSHPROPID_NextVisibleSibling, out variant));
currentItemID = (uint)(int)variant;
WalkSourceProjectAndAdd(sourceHierarchy, currentItemID, targetNode, true);
}
}
------------------

I've changed the code this way:
-------------------
....
variant = null;
ErrorHandler.ThrowOnFailure(sourceHierarchy.GetProperty(currentItemID, (int)__VSHPROPID.VSHPROPID_NextVisibleSibling, out variant));
currentItemID = (uint)(int)variant;
WalkSourceProjectAndAdd(sourceHierarchy, currentItemID, targetNode, false);
.....
-------------------

First of all you need to invoke GetProperty() with currentItemID parameter and second WalkSourceProjectAndAdd() should be called with addSibling=false.
Otherwise it enumerates sibling nodes in wrong way and calls this method several times for the same node.

Repro Steps:
Drag'n'Drop folder containing 2 file nodes.

Actual Results:
ApplicationException is risen in ProjectNode.AddNodeIfTargetExistInStorage() method.

Expected Results:
Drag'n'Drop works fine.

Created Issue: Fix: Unloading project without a References Node

paullunt — Fri, 23 Jan 2009 21:39:19 GMT

If the references node factory in ProjectNode is overridden to always return null. The project will trash when the project is unloaded.

See patch to resolve the issue.

Paul

Commented Issue: MPF projects in the solution block "Create Unit Tests" wizard

GasparNagy — Fri, 05 Dec 2008 06:58:35 GMT

To repro, you have to do the following:
1. You create a solution, with a standard c# class library.
2. You add a custom project to the solution that is based on MPF.
3. Go to "Class1" class of the class library.
4. Select "Create Unit Tests..." from the context menu of the class.
The window will be empty, and you cannot select Class1. If you unload the MPF-based project, the wizard works again.
Comments: ** Comment from web user: GasparNagy **

Here is my fix for the problem. The change is in the Output.cs and I have extended the unit test environment as well to be able to test this.

Commented Issue: MPF projects in the solution block "Create Unit Tests" wizard

GasparNagy — Thu, 04 Dec 2008 14:41:42 GMT

It seems that the problem is, that VS gets the OUTPUTLOC property from the Microsoft.VisualStudio.Project.Output class of the MPF-based project (get_Property). As this property is not supported, the method throws a NotImplementedException, but the wizard does not catch the exceptions by project so the entire wizard is disabled.

I have fixed it for myself by returning the output assembly path for this property:
if (string.Equals(szProperty, "OUTPUTLOC", StringComparison.OrdinalIgnoreCase))
{
value = output.GetMetadata(ProjectFileConstants.Include);
}

It could be also fixed in the ProjectElement class as well, but this is rather related to the IVsOutput2 interface, so it is better here IMHO. I did not find any documentation for OUTPUTLOC anyway...

It is very good that MPF came to codeplex. I would be happy to contribute as well.

Created Issue: MPF projects in the solution block "Create Unit Tests" wizard

GasparNagy — Thu, 04 Dec 2008 14:31:36 GMT

Closed Issue: MPF ProjectNode.GetProjectOptions() returns wrong configuration options

DmitryPavlov — Wed, 03 Dec 2008 07:14:32 GMT

Problem Description: There appears to be a bug in ProjectNode.GetProjectOptions(). At the top of the method, it checks to see if the current options field is not null, and if not, returns the existing options.

This logic is wrong, because it doesn't check to see if the cached options object matches the configuration specified in the config argument. This causes incorrect configuration options to be returned to the caller. Here is one scenario:

In a release configuration, user presses F5 to debug which cases ProjectConfig.DebugLaunch() to be called. If the "StartProgram" property is not set, GetOutputAssembly() is called to get the filename to debug. GetOutputAssembly() calls GetProjectOptions( "Release" ) but returns the ProjectOptions for a debug configuration if that was the last configuration that was read and cached.

This causes the path of the output assembly in a debug configuration to be returned. End result is that pressing F5 runs the debug build of the assembly, even in release mode.

Not sure what the best way to fix this is, but since the options field is private and there is no public or protected property around it, it can't be worked around in the project node subclass and requires a change in the base class code.

This bug exists in VS2005 as well. Could we please get this fixed in the next update to the SDK?

Repro Steps:
See description

Actual Results:
Wrong configuration data is returned causing Debug and Start Without Debugging commands to invoke the wrong file!

Expected Results:
The correct data should be returned

Commented Issue: ProjectNode does not allow SVsSccManager, SVsQueryEditQuerySave to be overrided to use custom SCC provider

DmitryPavlov — Wed, 03 Dec 2008 06:55:49 GMT

The current interface and implementation of ProjectNode.cs does not allow end user to change the SCC provider other than the default SVsSccManager or SVsQueryEditQuerySave.

sited methods are :
internal bool QueryEditProjectFile(bool suppressUI)
protected void RegisterSccProject()
protected void UnRegisterProject()

in all 3 functions, when the end user needs to implement custom SCC provider packages (in VS Isolated or integrated shell), the methods are closed off from extending and method always returns the default SCC provider and not the end-user custom SCC provider, causing SCC operations to be incorrectly executed.

I am proposing to fix this (add extensibility) by changing the interface to the following:

protected internal virtual bool QueryEditProjectFile(bool suppressUI)
protected virtual void RegisterSccProject()
protected virtual void UnRegisterProject()

Similar approaches were taken on other functions, as well as in the HierarchyNode.cs class.
Comments: ** Comment from web user: DmitryPavlov **

HI ProgrammerJoe,

Do you agree that this issue should be closed due to alinconstantin arguments?